Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating orphan branch #95

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Conversation

StrongMonkey
Copy link
Contributor

No description provided.

@StrongMonkey
Copy link
Contributor Author

This provides the ability to create an orphan branch if $INPUT_BRANCH doesn't exist.

@stefanzweifel
Copy link
Owner

Hi 👋

Never heard of orphan branches before. So I'm curious: in which scenarios are such branches useful?
If this should be merged, I would have to be able to answer possible questions.

Maybe you can give an example workflow file?

@StrongMonkey
Copy link
Contributor Author

@stefanzweifel Hi 👋 , thanks for replying!

This is actually a specific usecase that we want to commit on another branch, and if the branch doesn't exist, created an orphan branch(which has no git history).

We use this on one of our repo so that we can commit generated changes to another branch without creating empty branch manually. Here is an example https://github.com/StrongMonkey/charts-1/blob/branch-asset/.github/workflows/push.yml#L18-L22

@stefanzweifel
Copy link
Owner

Sounds reasonable.
I also searched a bit around and I think that's actually a pretty cool feature. Would have been helpful to now it exists in the past 😅

Will merge and tag a new version soon.

@stefanzweifel stefanzweifel merged commit 5c3c72f into stefanzweifel:master Sep 10, 2020
@pi0
Copy link

pi0 commented Sep 10, 2020

@stefanzweifel
Copy link
Owner

@pi0 Thanks for reporting! Seems this PR really has broken everything. Sorry for that.

The changes have been reverted in #97 and released in v4.5.1.

@StrongMonkey For your own workflows, you would have to revert to your fork for now. Will work on a test suite over the next few days/weeks to make sure new features can be added with confidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants